Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ext-session-lock-v1 #219

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Add support for ext-session-lock-v1 #219

merged 3 commits into from
Feb 2, 2022

Conversation

emersion
Copy link
Member

@emersion emersion commented Dec 20, 2021

This is a new protocol to lock the session 1. It should be more
reliable than layer-shell + input-inhibitor.

  • Bump wayland-protocols dep version

To build locally:

mkdir subprojects
git clone "git@gitlab.freedesktop.org:ifreund/wayland-protocols.git" -b ext-lock-v1 subprojects/wayland-protocols
meson configure build/ --force-fallback-for=wayland-protocols

The next commit will need that version. Adjust the build to not
trigger deprecation warnings.
This allows building swaylock with a local wayland-protocols.
@emersion emersion force-pushed the lock-proto branch 2 times, most recently from 7f0159a to 22acde7 Compare December 20, 2021 19:18
@emersion emersion changed the title Add support for ext-lock-v1 Add support for ext-session-lock-v1 Dec 20, 2021
Copy link
Member

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with the ext-session-lock-v1 implementation in river here riverwm/river#497 and the wl_surface_commit() call mentioned below removed when using ext-session-lock-v1.

main.c Outdated Show resolved Hide resolved
main.c Outdated Show resolved Hide resolved
main.c Show resolved Hide resolved
@emersion
Copy link
Member Author

emersion commented Jan 7, 2022

Addressed the comments, thanks for the review!

This is a new protocol to lock the session [1]. It should be more
reliable than layer-shell + input-inhibitor.

[1]: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants