Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: use strtoul in parse_color to avoid clamp #831

Merged
merged 1 commit into from
Aug 4, 2016
Merged

common: use strtoul in parse_color to avoid clamp #831

merged 1 commit into from
Aug 4, 2016

Conversation

progandy
Copy link
Contributor

@progandy progandy commented Aug 4, 2016 •
edited
Loading

Some implementations of strtol may clamp the values to LONG_MAX instead of
wrapping around to negative values, so use strtoul instead to parse colors.

(Mentioned in #343)

@progandy
common: use strtoul in parse_color to avoid clamp
bf4056a 
Some implementations of strtol may clamp the values to LONG_MAX instead of
wrapping around to negative values, so use strtoul instead to parse colors.
@ddevault ddevault merged commit 4b0de51 into swaywm:master Aug 4, 2016
@ddevault
Copy link
Contributor

ddevault commented Aug 4, 2016

Thanks!

@progandy progandy deleted the fix_colors branch August 4, 2016 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@progandy @ddevault