ipc: add an input event #4342
ipc: add an input event #4342
Conversation
RedSoxFan
force-pushed
the
ipc-event-input
branch
from
7a0d9ff
to
b9ff4b3
Compare
|
This is ready for review. I kept the |
This adds an ipc event related to input devices. Currently the following changes are supported: - added: when an input device becomes available - removed: when an input device is no longer available - xkb_keymap_changed: (keyboards only) the keymap changed - xkb_layout_changed: (keyboards only) the effective layout changed
This adds a libinput_config change type to the input event for when the libinput config for a device changes In order for this to be possible to track, the libinput config code had to be refactored. It is now extracted into a separate file to isolate it from the rest of the input management code.
RedSoxFan
force-pushed
the
ipc-event-input
branch
from
b9ff4b3
to
fb8b373
Compare
| @@ -1371,6 +1371,9 @@ available: | |||
| |- 0x80000014 | |||
| : bar_status_update | |||
| : Send when the visibility of a bar should change due to a modifier | |||
| |- 0x80000015 | |||
There was a problem hiding this comment.
Since i3 won't implement such an event, it may be wise to leave 0x80000015 for a future i3 event, and choose a much higher event code.
There was a problem hiding this comment.
bar_status_update is also Sway specific. I just added this one right after. Should they both be changed?
| @@ -603,8 +608,23 @@ void sway_keyboard_configure(struct sway_keyboard *keyboard) { | |||
| } | |||
| } | |||
|
|
|||
| bool keymap_changed = false; | |||
| bool effective_layout_changed = keyboard->effective_layout != 0; | |||
There was a problem hiding this comment.
Hmm, not sure I understand the logic here...
There was a problem hiding this comment.
Hmm, nevermind. It's the effective layout that gets reset.
However if the keymap changed the effective layout changes too, even if effective_layout is still zero. The effective layout depends on the keymap.
There was a problem hiding this comment.
Yes, but if the effective layout is 0 before and after, then either the entire keymap changed or the keymap is identical and there is no change to the effective layout. See #4343 for a follow-up for this
Closes #4334
This adds an ipc event related to input devices. Currently the
following changes are supported: