Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support server-side cursors for running queries #100

Merged
2 commits merged into from
Jan 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2021

In version 5.3.0 we're introducing the possibility to run parallel queries through server-side (a.k.a. named) cursors. To test this feature regularly in a fairly realistic scenario, we extended the benchmark toolkit to have a mode in which all queries are executed through server-side cursors (currently client-side cursors are used). This must be a separate mode because running queries against native PSQL would otherwise turn completely sequential.

See psycopg/psycopg2#941 for why turning the connection into transaction mode is so ugly.

@ghost ghost requested review from 0xfeedface, oferz and lucvlaming January 20, 2021 11:36
s64da_benchmark_toolkit/db.py Show resolved Hide resolved
s64da_benchmark_toolkit/db.py Show resolved Hide resolved
s64da_benchmark_toolkit/db.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ghost ghost force-pushed the feature/SDB-9484-support-using-named-cursor branch 2 times, most recently from 550d5c7 to d3780a8 Compare January 22, 2021 12:37
Copy link
Contributor

@lucvlaming lucvlaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for me as to keep risk small.

@ghost ghost force-pushed the feature/SDB-9484-support-using-named-cursor branch from d3780a8 to 6b3e625 Compare January 25, 2021 10:30
@ghost ghost changed the title Support named cursors for running queries Support server-side cursors for running queries Jan 25, 2021
README.md Outdated Show resolved Hide resolved
@ghost ghost merged commit d0d5596 into master Jan 25, 2021
@ghost ghost deleted the feature/SDB-9484-support-using-named-cursor branch January 25, 2021 20:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants