Add CLI option to start the game paused #2080
Conversation
app/game/Main.hs
Outdated
| appOpts :: Parser AppOpts | ||
| appOpts = do | ||
| userSeed <- seed | ||
| userScenario <- scenario | ||
| scriptToRun <- run | ||
| pausedAtStart <- paused | ||
| autoPlay <- autoplay | ||
| speed <- speedFactor | ||
| cheatMode <- cheat | ||
| colorMode <- color | ||
| userWebPort <- webPort | ||
| let repoGitInfo = gitInfo | ||
| return AppOpts {..} |
There was a problem hiding this comment.
Strange, it seems GHC 9.2 and 9.4 did not understand the ApplicativeDo I wanted to use here.
There was a problem hiding this comment.
Hmm, maybe they don't deal properly with ApplicativeDo + record wildcards?
There was a problem hiding this comment.
That is unfortunate. Perhaps just put it back the way it was, but add a comment (+ an issue?) to update the code once we drop support for GHC 9.4?
There was a problem hiding this comment.
Oh! Try using pure instead of return, perhaps? The error message says No instance for (Monad Parser) arising from a use of ‘return’
This page seems to indicate this style has been possible for a while: https://chshersh.com/recordwildcards
There was a problem hiding this comment.
The error message is wrong - the problem is in the line above containing let. As GHC docs note:
In particular, slight variations such as
return . Just $ xorlet x = e in return xwould not be recognised.
Later versions of GHC seem to have gotten better at this.
app/game/Main.hs
Outdated
| appOpts :: Parser AppOpts | ||
| appOpts = do | ||
| userSeed <- seed | ||
| userScenario <- scenario | ||
| scriptToRun <- run | ||
| pausedAtStart <- paused | ||
| autoPlay <- autoplay | ||
| speed <- speedFactor | ||
| cheatMode <- cheat | ||
| colorMode <- color | ||
| userWebPort <- webPort | ||
| let repoGitInfo = gitInfo | ||
| return AppOpts {..} |
There was a problem hiding this comment.
That is unfortunate. Perhaps just put it back the way it was, but add a comment (+ an issue?) to update the code once we drop support for GHC 9.4?
@byorgey, it's not just the first scenario you open; it changes the default for all scenarios to start paused. 🙂 I hope it is an understandable and useful behavior. Could you please also have a look at the added |
I think it should be in the UI state in preparation for asynchronous UI (pr/issue soon). |
Ah, that makes sense.
On the contrary, I think it does belong in |
|
Thanks, @byorgey for thinking that through - that explanation could well be a note in Temporal Game State. 👍 |
You can test it with:
After one step (Ctrl+O) the Goal dialog will show up along with the rest of the UI.