-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight error part in REPL #1957
Conversation
@byorgey could you please have a look? It only works to a degree, and I suspect there are bugs:
Feel free to push to this branch if you find anything; I am out of ideas for today. 😄 |
Co-authored-by: Restyled.io <commits@restyled.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part of the prompt being highlighted does not seem correct. It always seems to extend from the beginning of the error all the way to the end of the line, no matter what. For example, when I entered build {(place 2); move }
everything from 2
to the closing }
is red.
Co-authored-by: Restyled.io <commits@restyled.io>
@byorgey, after reading your comment again, I found the arithmetic bug that extended the range. 👍 |
Co-authored-by: Restyled.io <commits@restyled.io>
Should work well now. Please have a look. I hit up through my history and it seemed nicely highlighted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! All the examples I tried seemed nicely highlighted too. Thanks for putting this together, it's a very nice feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely!
Closes #1956