Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitelist walkable entities #1721

Merged
merged 2 commits into from
Mar 10, 2024
Merged

whitelist walkable entities #1721

merged 2 commits into from
Mar 10, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jan 8, 2024 •
edited
Loading

A walkability "blacklist" had already been implemented in #1536. The whitelist shall only permit walking on the specified entities; blank cells become unwalkable.

This feature would allow use of the path command to check for "connectivity" by way of a "trail" of entities.

Use cases

  • system robots or goal conditions can use this to check whether the player has connected two points with a road, cable, aqueduct, etc.
  • monkeys, which can only move along trees
  • sea life, which should only be able to move in water

Testing

scripts/run-tests.sh --test-arguments '--pattern "walkable-entities"'

@kostmo kostmo force-pushed the feature/walkable-whitelist branch from d2b2474 to 5c4e0b3 Compare January 22, 2024 00:44
@restyled-io restyled-io bot mentioned this pull request Jan 22, 2024
Closed
@kostmo kostmo changed the title whitelist walkable entities [WIP] whitelist walkable entities Jan 22, 2024
@kostmo kostmo force-pushed the feature/walkable-whitelist branch from 5c4e0b3 to 2f57ead Compare January 22, 2024 00:49
@kostmo kostmo mentioned this pull request Jan 22, 2024
Draft
@kostmo kostmo force-pushed the feature/walkable-whitelist branch from 2f57ead to 845a9bd Compare March 6, 2024 06:17
@restyled-io restyled-io bot mentioned this pull request Mar 7, 2024
Closed
@kostmo kostmo force-pushed the feature/walkable-whitelist branch from 6258b7b to fd98bac Compare March 9, 2024 07:36
@kostmo kostmo changed the title [WIP] whitelist walkable entities whitelist walkable entities Mar 9, 2024
@kostmo kostmo force-pushed the feature/walkable-whitelist branch 3 times, most recently from 87dd4b8 to 568fd81 Compare March 9, 2024 08:05
@kostmo kostmo marked this pull request as ready for review March 9, 2024 08:07
@kostmo kostmo requested a review from byorgey March 9, 2024 08:07
@kostmo kostmo force-pushed the feature/walkable-whitelist branch from 568fd81 to 5e593c4 Compare March 9, 2024 08:14
byorgey
byorgey approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/swarm-engine/Swarm/Game/Step/Path/Walkability.hs Outdated Show resolved Hide resolved
@kostmo @byorgey
Update src/swarm-engine/Swarm/Game/Step/Path/Walkability.hs
2f7f418 
Co-authored-by: Brent Yorgey <byorgey@gmail.com>
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 10, 2024
@mergify mergify bot merged commit 7d3f263 into main Mar 10, 2024
11 checks passed
@mergify mergify bot deleted the feature/walkable-whitelist branch March 10, 2024 01:32
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey