Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude_final_dir option for jobs #35

Merged
merged 2 commits into from
May 9, 2021
Merged

Add exclude_final_dir option for jobs #35

merged 2 commits into from
May 9, 2021

Conversation

Acaki
Copy link
Contributor

@Acaki Acaki commented Apr 30, 2021

Add ability to specify -x for chia plots create
Useful when you're plotting to a network drive, that has its own harvester running

螢幕擷取畫面 2021-04-30 173801

@swar
Copy link
Owner

swar commented Apr 30, 2021

This is great @Acaki

My only request is can you change "dir" to "directory" so it stays consistent with the other places I am using directory? Nice work!

@swar
Copy link
Owner

swar commented Apr 30, 2021

Oh also you'll want to add that value to the Job object as well

https://github.com/swar/Swar-Chia-Plot-Manager/blob/main/plotmanager/library/utilities/objects.py

@Acaki
Copy link
Contributor Author

Acaki commented Apr 30, 2021

Thanks, all done

@cdgraff
Copy link

cdgraff commented May 6, 2021

Hi @swar I'm searching for the same feature, can merge please? thanks!

@daryledesilva
Copy link

daryledesilva commented May 6, 2021 via email

@swar
Copy link
Owner

swar commented May 9, 2021

Sorry everyone, it's been a very busy week in terms of keeping up with questions and then getting some time to dedicate to making changes.

@swar swar changed the base branch from main to development May 9, 2021 18:55
@swar swar merged commit 9927052 into swar:development May 9, 2021
@swar swar mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants