Moving deepcopy of defaults to prevent pickle issue during parse_args

swansonk14 · Jun 28, 2023 · 33e7c53 · 33e7c53
1 parent 7f12646
commit 33e7c53
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/tap/tap.py b/tap/tap.py
@@ -140,7 +140,8 @@ def _add_argument(self, *name_or_flags, **kwargs) -> None:
 
         # Get default if not specified
         if hasattr(self, variable):
-            kwargs['default'] = kwargs.get('default', getattr(self, variable))
+            # Deepcopy to prevent mutation of default values
+            kwargs['default'] = deepcopy(kwargs.get('default', getattr(self, variable)))
 
         # Set required if option arg
         if (
@@ -456,8 +457,8 @@ def parse_args(self: TapType,
                     elif var_type in (Tuple, tuple):
                         value = tuple(value)
 
-            # Set variable in self (and deepcopy to prevent mutation of default values)
-            setattr(self, variable, deepcopy(value))
+            # Set variable in self
+            setattr(self, variable, value)
 
         # Process args
         self.process_args()