Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config for html title #180

Merged
merged 3 commits into from
Nov 19, 2021
Merged

feat: config for html title #180

merged 3 commits into from
Nov 19, 2021

Conversation

link-duan
Copy link
Contributor

Describe the PR
config for html title

swagger.go Show resolved Hide resolved
@ubogdan
Copy link
Contributor

ubogdan commented Nov 17, 2021

I guess there is no open issue for this.
Before you follow the requested changes please describe your use case so we can better understand the need.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #180 (49630de) into master (301224e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           87        91    +4     
=========================================
+ Hits            87        91    +4     
Impacted Files Coverage Δ
swagger.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301224e...49630de. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Nov 18, 2021

Can you please give us some insights regarding the use case?

@link-duan
Copy link
Contributor Author

link-duan commented Nov 19, 2021

Can you please give us some insights regarding the use case?

The title of swagger web page (/swagger/index.html) is "Swagger UI".
If we open multiple "Swagger UI" pages, it's hard to find the one we want from browser tabs.
So I think it's a good idea to support the customization of page title.

@ubogdan ubogdan merged commit 74c905c into swaggo:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants