Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"gulp less" changes source files #1710

Closed
dolmen opened this issue Oct 28, 2015 · 6 comments · Fixed by #2164
Closed

"gulp less" changes source files #1710

dolmen opened this issue Oct 28, 2015 · 6 comments · Fixed by #2164

Comments

@dolmen
Copy link
Contributor

dolmen commented Oct 28, 2015

gulp less applied on 2fced78 changes src/main/html/css/print.css and src/main/html/css/screen.css:

--- a/src/main/html/css/print.css
+++ b/src/main/html/css/print.css
@@ -82,7 +82,7 @@
 .swagger-section pre .vhdl .attribute,
 .swagger-section pre .clojure .attribute,
 .swagger-section pre .coffeescript .property {
-  color: #8888ff;
+  color: #88F;
 }
 .swagger-section pre .keyword,
 .swagger-section pre .id,
--- a/src/main/html/css/screen.css
+++ b/src/main/html/css/screen.css
@@ -82,7 +82,7 @@
 .swagger-section pre .vhdl .attribute,
 .swagger-section pre .clojure .attribute,
 .swagger-section pre .coffeescript .property {
-  color: #8888ff;
+  color: #88F;
 }
 .swagger-section pre .keyword,
 .swagger-section pre .id,

I'm a modern JS toolchain beginner (I just installed the toolchain), so if you want the exact version of some components of my toolchain, you have to tell me exactly how to do that.

@dolmen
Copy link
Contributor Author

dolmen commented May 19, 2016

Still happens on v2.1.4.

This issue is painful when maintaining a fork of swagger-ui.

@dolmen
Copy link
Contributor Author

dolmen commented May 19, 2016

Having a look at the git log at print.css, there seems to be a conflict of tools used by committers @fehguy @bodnia :

@dolmen
Copy link
Contributor Author

dolmen commented May 19, 2016

The issue seems to be that some people commit in src/main/html/css/*.css instead of src/main/less/*.less.

I think that src/main/html/css/*.css should be removed from the repo and excluded with a .gitignore to ensure everyone commits in LESS.

@bodnia
Copy link
Contributor

bodnia commented May 19, 2016

@dolmen it's agreed with @fehguy to commit the dist files so that everyone who downloads swagger-ui shouldn't build it, but use it right after downloading.
Hope this helps!

@dolmen
Copy link
Contributor Author

dolmen commented May 19, 2016

@bodnia The issue is not about dist/. I understand the intent for that directory.

The issue is about src/main/html/css.

@bodnia
Copy link
Contributor

bodnia commented May 19, 2016

@dolmen sorry for misunderstanding. I meant less files compiled to css and put into folder src/main/html/css
https://github.com/swagger-api/swagger-ui/blob/master/gulpfile.js#L84-97

updated url.

dolmen added a commit to dolmen/swagger-ui that referenced this issue May 19, 2016
In ceb6655 (swagger-api#2130), CSS code has been
changed in src/main/html/csss/{print,screen}.css instead of LESS source.
This commit resynchronize the source with the generated code.
fehguy added a commit that referenced this issue May 19, 2016
Sync specs.less with {print,screen}.css (#1710)
vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this issue Aug 19, 2016
In ceb6655 (swagger-api#2130), CSS code has been
changed in src/main/html/csss/{print,screen}.css instead of LESS source.
This commit resynchronize the source with the generated code.
vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this issue Aug 19, 2016
kodekracker pushed a commit to 91springboard/swagger-ui that referenced this issue Mar 2, 2017
In ceb6655 (swagger-api#2130), CSS code has been
changed in src/main/html/csss/{print,screen}.css instead of LESS source.
This commit resynchronize the source with the generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants