This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
Set all properties besides those in option as required #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this makes a lot of sense, but is potentially breaking behavior for older versions of the library. It at least deserves a point in the README. Could you please add that? |
|
@fehguy Finally had a moment to update the PR fixing merge conflicts and adding a bit in the README. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #7
Defaults to all properties being set to required unless wrapped in
Optionor if manually overridden by an annotation.This change is not implemented in #23 and would need some tweaks if that's merged first.