SWG-9288 utilizing safe url resolver for OAS 2.0 #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add tests soon & similar PR to v3 parser |
frantuma
requested changes
Jan 8, 2024
| @@ -66,6 +66,27 @@ public ResolverCache(Swagger swagger, List<AuthorizationValue> auths, String par | |||
| this.swagger = swagger; | |||
There was a problem hiding this comment.
instead of duplicating logic in constructor I would suggest to call this(swagger, auths, parentFileLocation, new ParseOptions())
| @@ -49,6 +50,16 @@ public SwaggerResolver(Swagger swagger, List<AuthorizationValue> auths, String p | |||
| parametersProcessor = new ParameterProcessor(cache, swagger); | |||
| } | |||
|
|
|||
| public SwaggerResolver(Swagger swagger, List<AuthorizationValue> auths, String parentFileLocation, Settings settings, ParseOptions parseOptions) { | |||
There was a problem hiding this comment.
instead of duplicating logic in constructor I would suggest to call in constructor above this(swagger, auths, parentFileLocation, settings, new ParseOptions())
Great shout, commited changes! Sorry for taking so long to apply the feedback, had to urgently finish other stuff last days. |
frantuma
approved these changes
Jan 11, 2024
CalemRoelofsSB
approved these changes
Jan 11, 2024
MiloszTarka
deleted the
SWG-9288-utilizing-safe-url-resolver-for-oas-20
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2030
This PR makes swagger-parser to utilizes safeUrlResolver when resolving OpenAPI 2.0 definitions.
The reason behind this change is described deeply under the following PR:
#1910
The $refs are checked in ResolverCache class, in loadRef method.
In order to keep the backward compatibility, I've created a new constructor of ResolverCache so it is possible to explicitly pass the parseOptions through the SwaggerResolver.