Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser-v3: Fix incorrect path separators when resolving schema ref on Windows OS (issue 1886) #1959

Closed
wants to merge 1 commit into from

Conversation

walaniam
Copy link
Contributor

This PR is to fix issue 1886

When parsing openapi definitions the results are different on Linux and Windows systems. It has been documented with the test: OpenAPIV3ParserTest#testIssue1886.

On Linux OS the schemas (with and without the fix) are resolved to:
ArrayPojo, Enum1, Enum1_1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, additional-properties, array-pojo, locale-translation-item, map-pojo, set-pojo, simple-pojo, translation-item

On Windows OS, without this fix, schemas are resolved to following names:
ArrayPojo, Enum1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, schemas\array-pojo, schemas\enum1, schemas\map-pojo, schemas\set-pojo, schemas\simple-pojo

@dexterxx-pl
Copy link

Yo,
Any chances pushing this PR / updating it?

@walaniam
Copy link
Contributor Author

walaniam commented Mar 6, 2024

@dexterxx-pl I have opened a new clean one #2064

@walaniam walaniam closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative $refs fail on Windows due to potential issue in ExternalRefProcessor#processRefToExternalSchema
2 participants