Issue-1891: Fix for mixed folder and classpath references not resolving. #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracekarina
approved these changes
Mar 14, 2023
|
Thanks @gracekarina for accepting and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1891
Normally, in order to properly test resolving a reference with an absolute path, I would need access to a jar that can be read by the class loader. However, by using folders, I was able to simulate this by placing the file that is referred to in the contract outside of the directory in which the rest of the test resources are located. This causes the
ClasspathHelperto be used to resolve the absolute reference and the test passes as desired.Also verified that if I remove the change to
ExternalRefProcessorthat the test fails, so I know the branch in the updated code is being executed by the test.