Paths defined as $ref wont add parameters to each operation #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When organizing path definitions in different files like the example below, the parameters will not be passed from the top-level
/ref/test/{id}/toplevelparam
definition to theGET
operation.api.yaml
:test-endpoints.yaml
:The issue is that the passing of parameters to the operations is done before parsing of the
$ref
s.Solution
By calling
addParametersToEachOperation
after all the$ref
s has been processed, the parameters can be correctly added.I have included simple tests of
PathProcessor
for this specific case. I am not sure if I have structured the tests correctly or if they make more sense to include inOpenAPIResolverTest