Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another Null Pointer #150

Merged
merged 2 commits into from
Dec 16, 2015
Merged

Another Null Pointer #150

merged 2 commits into from
Dec 16, 2015

Conversation

rstanton
Copy link
Contributor

Looks like there was another issue in my commit - if the spec being processed had an internal ref it ended up generating a null pointer exception when processRefToExternalDefinition() was recursively called as the Model was null when pulled from the cache.

Added a check to make sure it's an external ref before processing. This does lead to a situation in which some definitions are left unprocessed

internal reference existed within a external referenced spec.

This currently leaves the internal reference unprocessed.
internal reference existed within a external referenced spec.

This currently leaves the internal reference unprocessed.
fehguy added a commit that referenced this pull request Dec 16, 2015
@fehguy fehguy merged commit d4be132 into swagger-api:master Dec 16, 2015
@fehguy fehguy modified the milestone: v1.0.15 Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants