Malformed Spec Causes NPE

[ricekot]

Parsing the following spec:

{
   "notswagger:"x.0"
}

results in an NPE instead of returning a list of errors.

This may be happening because out.getOpenAPI() is nullable at:

swagger-parser/modules/swagger-parser-v2-converter/src/main/java/io/swagger/v3/parser/converter/SwaggerConverter.java

Line 114 in 1670890

new ResolverFully(options.isResolveCombinators()).resolveFully(out.getOpenAPI());

Stack trace:

java.lang.NullPointerException
	at io.swagger.v3.parser.util.ResolverFully.resolveFully(ResolverFully.java:61)
	at io.swagger.v3.parser.converter.SwaggerConverter.readResult(SwaggerConverter.java:114)
	at io.swagger.v3.parser.converter.SwaggerConverter.readLocation(SwaggerConverter.java:92)
...

[gracekarina]

Hi @ricekot thanks for reporting this issue, we have added a pr with a test and the fix. Please reopen if this keep happening.

[ricekot]

It seems that the NPE is resolved, but the error is still not reported. The spec I provided above is deliberately malformed, and the SwaggerParserResult object should contain the following (or similar) error message:

Unexpected character ('x' (code 120)): was expecting a colon to separate field name and value
 at [Source: (String)"{
  "notswagger:"x.0"
}

This is printed to the output but not returned in the error messages list.

[gracekarina]

@ricekot please check, I have added a solution for the messages don't get lost in the process of conversion.

[ricekot]

Yes, thank you, this issue is resolved now.