Merge Path and Operation parameters #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ergePath-OpParams
saharj
changed the title
buunguyen
suggested changes
Mar 24, 2017
src/execute.js
Outdated
| // Add values to request | ||
| arrayOrEmpty(operation.parameters).forEach((parameter) => { | ||
| arrayOrEmpty(operation.parameters) // operation parameters | ||
| .concat(arrayOrEmpty(spec.paths[pathName].parameters)) // path parameters |
There was a problem hiding this comment.
Please add indent to this and the next line
| } | ||
| } | ||
|
|
||
| const req = buildRequest({ spec, operationId: 'getPetsById', parameters: { id: 123, test: 567 } }) |
There was a problem hiding this comment.
Please remove empty space inside {}.
| @@ -60,6 +60,9 @@ export function eachOperation(spec, cb, find) { | |||
| // Iterate over the spec, collecting operations | |||
| for (const pathName in paths) { | |||
| for (const method in paths[pathName]) { | |||
| if (method.toUpperCase() === 'PARAMETERS') { | |||
There was a problem hiding this comment.
What is this check for? Would be great to add a comment clarifying the intention.
There was a problem hiding this comment.
@buunguyen Oddly, when path-parameters come before the operation like below, the method becomes PARAMETERS (here it should be GET), and that causes problems.
paths: {
'/pet/{id}': {
parameters: [
{...}
],
get: {
operationId: 'getPetsById',
parameters: [
{...}
],
}
}
}
There was a problem hiding this comment.
I see. The loop iterates the keys of each path, so "parameters" will appear. Doesn't matter if it appears before or after the "get".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965