fix(execute): serialize req.cookies into valid cookie-string #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/execute/index.js: Evaluated as low risk
char0n
commented
Jan 7, 2025
|
Needs rebase before merging |
Every Cookie header produced by this library can now be properly parsed by RFC 6265 parser, and resulting cookie-value can be further percent decoded and processed by RFC 6570 implementations
char0n
force-pushed
the
char0n/cookie-parameters
branch
from
9dffb5b to
611527a
Compare
|
🎉 This PR is included in version 3.33.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of aligning with OpenAPI 3.0.4 clarifications.
Specifically this PR is aligning implementations around cookies with https://spec.openapis.org/oas/v3.0.4.html#appendix-d-serializing-headers-and-cookies.
swagger-clientwill now product valid cookies, which can be processed by RFC 6265 parser,cookie-valueis percent decoded and can be further processed by RFC 6570 implementation.