Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue circular ref not resolved if baseDoc is provided #1031

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

buunguyen
Copy link
Contributor

@buunguyen buunguyen commented Apr 27, 2017

@shockey
Copy link
Contributor

shockey commented Apr 28, 2017

Confirmed fix for swagger-api/swagger-ui#2889 and swagger-api/swagger-ui#2923. LGTM! Thanks for this @buunguyen.

@shockey shockey merged commit 3d1deca into swagger-api:master Apr 28, 2017
@buunguyen buunguyen deleted the fix-cyclic-more branch May 3, 2017 22:44
@gaurav517
Copy link

I see same error in version 3.13.6.

  • OS: macOS
  • Browser: chrome
  • Version: 66.0.3359.181
  • Swagger-UI version: 3.13.6
  • Swagger/OpenAPI version: Swagger 2.0

In case of big nested request/response json spec, I get following in console after trying to expand the operation in swagger-ui and the section of operation shows endless spinner. After refreshing we see the operation details.

system.js:461 RangeError: Maximum call stack size exceeded
    at immutable.js:2405
    at Le.pe.withMutations (immutable.js:1353)
    at He (immutable.js:2405)
    at Le.set (immutable.js:2096)
    at nt (immutable.js:2780)
    at Ze.set (immutable.js:2686)
    at immutable.js:2651
    at immutable.js:3016
    at immutable.js:2699
    at Le.__iterate (immutable.js:2206)

@gaurav517
Copy link

created followup issue swagger-api/swagger-ui#4637

@ghost
Copy link

ghost commented Aug 8, 2019

Could you please clarify what does "baseDoc" mean ? How can we skip that ?

@ghost
Copy link

ghost commented Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants