Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] converts first 2 letters of a property name to lower case if started with 2 upper case letters #4073

Merged
merged 2 commits into from
Nov 1, 2016

Conversation

schnabel
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

The fix converts the first two letters of a property name to lower case if the property name started with two upper case letters.
Another way to handle the problem jackson has with uppercase properties would be to put the JsonProperty annotation to the getter methods.

@wing328 wing328 merged commit 32edf04 into swagger-api:master Nov 1, 2016
@wing328
Copy link
Contributor

wing328 commented Nov 1, 2016

@schnabel thanks for the PR, which has been merged into master.

@schnabel
Copy link
Contributor Author

schnabel commented Nov 1, 2016

@wing328 Hi, I will provide a fix for #4066 now.

@schnabel schnabel deleted the issue-4051 branch November 1, 2016 09:19
@wing328 wing328 changed the title bugfix: issue-4051 [Java] converts first 2 letters of a property name to lower case if started with 2 upper case letters Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants