Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password to psql in production entrypoint #1205

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Conversation

joren485
Copy link
Contributor

@joren485 joren485 commented Sep 5, 2020

Summary

The Postgres Docker has a recent change that requires to either disable password authentication (using POSTGRES_HOST_AUTH_METHOD=trust) or set a superuser password.

Although, this is not an immediate problem for us, because the password settings are only checked when the database is created, we should support the new behaviour.

This PR lets Concrexit check the connectivity to the Postgres database using the thalia database credentials instead of the superuser (postgres). This way, the connectivity check is not dependent on the specific superuser password settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

Thank you for opening a pull request.

@codeclimate
Copy link

codeclimate bot commented Sep 5, 2020

Code Climate has analyzed commit 8f46b0c and detected 0 issues on this pull request.

View more on Code Climate.

@joren485 joren485 marked this pull request as ready for review September 5, 2020 16:36
@pingiun pingiun merged commit 4af72f4 into master Sep 6, 2020
@pingiun pingiun deleted the psql-password branch September 6, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants