Skip to content

Commit

Permalink
[Backport to 13] Update LongConstantCompositeINTEL to LongCompositesI…
Browse files Browse the repository at this point in the history
…NTEL capability after Headers change (KhronosGroup#2312)

The original change:
KhronosGroup@0166a0f

* Bump SPIRV-Headers to 1c6bb2743599e6eb6f37b2969acc0aef812e32e3
* replace internal SPV_INTEL_long_composites ext with the published SPV_INTEL_long_composites
* don't rename extension for now
  • Loading branch information
vmaksimo authored Jan 23, 2024
1 parent 6fbace8 commit 0c7e711
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
4 changes: 3 additions & 1 deletion include/LLVMSPIRVExtensions.inc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ EXT(SPV_INTEL_variable_length_array)
EXT(SPV_INTEL_fp_fast_math_mode)
EXT(SPV_INTEL_fpga_cluster_attributes)
EXT(SPV_INTEL_loop_fuse)
EXT(SPV_INTEL_long_constant_composite)
EXT(SPV_INTEL_long_composites)
EXT(SPV_INTEL_long_constant_composite) // TODO: rename to
// SPV_INTEL_long_composites later
EXT(SPV_INTEL_optnone)
EXT(SPV_INTEL_fpga_dsp_control)
EXT(SPV_INTEL_memory_access_aliasing)
Expand Down
2 changes: 1 addition & 1 deletion lib/SPIRV/libSPIRV/SPIRVEntry.h
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ class SPIRVContinuedInstINTELBase : public SPIRVEntryNoId<OC> {
}

SPIRVCapVec getRequiredCapability() const override {
return getVec(CapabilityLongConstantCompositeINTEL);
return getVec(CapabilityLongCompositesINTEL);
}

llvm::Optional<ExtensionID> getRequiredExtension() const override {
Expand Down
2 changes: 1 addition & 1 deletion lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
add(CapabilityBitInstructions, "BitInstructions");
add(CapabilityAtomicFloat32AddEXT, "AtomicFloat32AddEXT");
add(CapabilityAtomicFloat64AddEXT, "AtomicFloat64AddEXT");
add(CapabilityLongConstantCompositeINTEL, "LongConstantCompositeINTEL");
add(CapabilityLongCompositesINTEL, "LongCompositesINTEL");
add(CapabilityAtomicFloat16AddEXT, "AtomicFloat16AddEXT");
add(CapabilityDebugInfoModuleINTEL, "DebugInfoModuleINTEL");

Expand Down
2 changes: 1 addition & 1 deletion spirv-headers-tag.conf
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0bcc624926a25a2a273d07877fd25a6ff5ba1cfb
1c6bb2743599e6eb6f37b2969acc0aef812e32e3
2 changes: 1 addition & 1 deletion test/SpecConstants/long-spec-const-composite.ll
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
target triple = "spir64-unknown-unknown"

; CHECK-SPIRV: Capability LongConstantCompositeINTEL
; CHECK-SPIRV: Capability LongCompositesINTEL
; CHECK-SPIRV: Extension "SPV_INTEL_long_constant_composite"
; CHECK-SPIRV: Decorate [[First:[0-9]+]] SpecId 0
; CHECK-SPIRV: Decorate [[Last:[0-9]+]] SpecId 65548
Expand Down
2 changes: 1 addition & 1 deletion test/long-constant-array.ll
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
; TODO: run validator once it supports the extension
; RUNx: spirv-val %t.spv

; CHECK-SPIRV: Capability LongConstantCompositeINTEL
; CHECK-SPIRV: Capability LongCompositesINTEL
; CHECK-SPIRV: Extension "SPV_INTEL_long_constant_composite"
; CHECK-SPIRV: TypeInt [[TInt:[0-9]+]] 8
; CHECK-SPIRV: Constant {{[0-9]+}} [[ArrSize:[0-9]+]] 78000
Expand Down
2 changes: 1 addition & 1 deletion test/long-type-struct.ll
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

; RUN: not llvm-spirv %t.bc -o %t.spv 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR

; CHECK-SPIRV: Capability LongConstantCompositeINTEL
; CHECK-SPIRV: Capability LongCompositesINTEL
; CHECK-SPIRV: Extension "SPV_INTEL_long_constant_composite"
; CHECK-SPIRV: TypeForwardPointer [[TFwdPtr:[0-9]+]]
; CHECK-SPIRV: TypeInt [[TInt:[0-9]+]]
Expand Down

0 comments on commit 0c7e711

Please sign in to comment.