Add support for README.txt and README files #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atreyagaurav
force-pushed
the
master
branch
from
4b51f00
to
4199d58
Compare
Atreyagaurav
force-pushed
the
master
branch
from
4199d58
to
6efac46
Compare
|
Additional points: It's trivial to add support for README.html, we can just insert the file contents to readme div, should I? I don't know if people use htmls as readme. But it might help if people want some advanced formatting or to convert unsupported formats to html (which preserves more info then converting to markdown). |
|
Hm I'm not sure about README.html as it might open us up to some weird and unforeseen JavaScript injection attacks in conjunction with uploads. Let's keep it to known formats. |
|
Implementation looks very good and I appreciate the easily expandable test. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added support for readme.md I thought it'd be easy enough to do readme.txt and just plain readme.
I was thinking of adding support for readme.org like in GitHub but didn't find any libraries that can convert it easily.
Also, if I rename "README.md" from miniserve to .txt, it only shows a fraction of the file contents, I can't debug it...