-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: static file support route_prefix #835
Conversation
Thanks! Any chance you could also make sure this is tested by one of the tests? Otherwise we might get regressions again. |
|
Also check out the CI which failed due to some formatting problem. :) |
@solarknight Hey, you still looking into this? |
5d41dd8
to
cc274ee
Compare
Hey, finally I complete the test for static file route check (really a newbie to rust). |
Could you rebase this so the history becomes tidier? |
tests/config.rs
Outdated
use rstest::rstest; | ||
use select::{document::Document, predicate::Attr}; | ||
|
||
#[rstest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you stick this test into serve_request.rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, rename the test to keep consistent with existing tests.
cc274ee
to
e571258
Compare
@svenstaro All above suggestions should be applied, please review the changes. |
Very cool, thanks! |
Use purely random route for static files if --random-route enabled, otherwise add route_prefix before generated route