Add backslash to percent_encode_sets.PATH_SEGMENT #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance for a test? I think it should be trivial as you can probably just add an entry to the file fixtures with this name. |
|
Oh yes! I somehow thought there was already a file with a backslash, but the backslash was just escaping another character ^^ Added a test and it works :) |
Jikstra
force-pushed
the
fix_percent_encdoing_backslash
branch
from
ce4b74b
to
f5cbd73
Compare
|
Ay the test now fails on windows, i guess creating a file with a backslash on windows panics? Is there some cool macro that we could add to that file so that it doesnt get created on windows? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545