Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for the --header parameter #1389

Merged
merged 12 commits into from
Apr 26, 2024
Merged

Improve documentation for the --header parameter #1389

merged 12 commits into from
Apr 26, 2024

Conversation

orwithout
Copy link
Contributor

A more detailed explanation of the use of the parameter --header

Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Now that I think about it, we could make even improve that. I left a comment.

src/args.rs Show resolved Hide resolved
Copy link
Contributor Author

@orwithout orwithout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. Here are the updates made:

  • Improved Documentation: Enhanced clarity on --header usage, particularly regarding how conflicts with existing headers are handled.

  • HSTS Example: Added an example in the README for enabling HSTS using --header, essential for achieving an A+ rating on SSL Labs.

  • Fullchain Certificates Usage: Documented the use of fullchain certificates with the --tls-cert option to improve HTTPS security.

These changes aim to clarify usage and enhance security features. Please let me know if additional modifications are necessary.

@svenstaro svenstaro merged commit c85d9e3 into svenstaro:master Apr 26, 2024
17 checks passed
@svenstaro
Copy link
Owner

Thanks!

svenstaro added a commit that referenced this pull request Apr 26, 2024
@orwithout
Copy link
Contributor Author

Thanks!

Glad to contribute! And it means a lot to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants