Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some optional serde implementations, as well as .clone on BVH #74

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Sep 2, 2021

No description provided.

@svenstaro
Copy link
Owner

I'm generally fine with this but make the CI happy. :)

@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 3, 2021

Looks like nightly just flat-out breaks a dependency deep in the tree (num-bigint)

rust-num/num-bigint#219
rust-lang/rust#88617

I'll wait until num-bigint gets a patch and then prompt CI to rerun.

@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 3, 2021

First-time contributors need a maintainer to approve running workflows.

Can you approve? 😄

@codecov-commenter
Copy link

Codecov Report

Merging #74 (46cc3f1) into master (4554a9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files           9        9           
  Lines        1564     1564           
=======================================
  Hits         1253     1253           
  Misses        311      311           
Impacted Files Coverage Δ
src/aabb.rs 93.29% <ø> (ø)
src/bvh/bvh_impl.rs 61.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4554a9a...46cc3f1. Read the comment docs.

@svenstaro svenstaro merged commit 69397f9 into svenstaro:master Sep 4, 2021
@svenstaro
Copy link
Owner

Cool, thanks!

@aidanhs aidanhs deleted the aphs-serde branch September 4, 2021 12:49
@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 4, 2021

Thanks for quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants