-
Notifications
You must be signed in to change notification settings - Fork 14
Fix install:git, make:database, update:env commands #14
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ class Make extends BaseCommand | |
protected $optionMap = [ | ||
'user' => 'user', | ||
'password' => 'password', | ||
'name' => 'name', | ||
]; | ||
|
||
/** | ||
|
@@ -27,6 +28,7 @@ public function configure() | |
->addArgument('server', InputArgument::REQUIRED, 'The id of the server to create the database on.') | ||
->addOption('user', null, InputOption::VALUE_REQUIRED, 'The username of an (optional) database user to create.', null) | ||
->addOption('password', null, InputOption::VALUE_REQUIRED, 'The password of the database user. Required with "user".', null) | ||
->addOption('name', null, InputOption::VALUE_REQUIRED, 'The name of the database user.', null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually the name of the database to create, not the name of the database user 🙂 |
||
->setDescription('Create a new database.'); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,13 @@ | |
|
||
class Update extends BaseCommand | ||
{ | ||
/** | ||
* @var array | ||
*/ | ||
protected $optionMap = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not required when the keys are the same as the values. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'file' => 'file', | ||
]; | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,14 @@ | |
|
||
class InstallGit extends BaseCommand | ||
{ | ||
/** | ||
* @var array | ||
*/ | ||
protected $optionMap = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not required when the keys are the same as the values. |
||
'provider' => 'provider', | ||
'repository' => 'repository', | ||
]; | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
ftell()
returns the position of the pointer. I'd be happy to useftell(STDIN) !== false
if you were looking for more type-safety here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree)