feat: Add sanitizer for tiktok #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedayak
force-pushed
the
feature/tiktok
branch
3 times, most recently
from
b7d379f to
b43e3d8
Compare
svenjacobs
requested changes
Oct 25, 2023
...main/src/main/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/tiktok/TiktokSanitizer.kt
Outdated
Show resolved
Hide resolved
...main/src/main/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/tiktok/TiktokSanitizer.kt
Outdated
Show resolved
Hide resolved
.../src/test/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/tiktok/TiktokSanitizerTest.kt
Outdated
Show resolved
Hide resolved
That is correct. Leon would have to perform network requests to unwrap these short URLs which is not desired. |
Note some sharing interfaces in the app give you shortened links (https://vt.tiktok.com/fr54gr6rf3e) that expand to the links matched here, but there isn't infrastructure in the app currently to deal with them.
yedayak
force-pushed
the
feature/tiktok
branch
from
b43e3d8 to
d7600f1
Compare
|
@all-contributors please add @yedayak for code |
|
I've put up a pull request to add @yedayak! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note some sharing interfaces in the app give you shortened links (like https://vt.tiktok.com/fr54gr6rf3e) that expand to the links matched here, but there isn't infrastructure in the app currently to deal with them.