Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple components #72

Merged
merged 12 commits into from
Apr 2, 2017
Merged

Multiple components #72

merged 12 commits into from
Apr 2, 2017

Conversation

Rich-Harris
Copy link
Member

This is almost done but not quite — need to style up the example selector, and do a bunch more testing. I'd also like to organise the examples a bit — there need to be a lot more examples, so we could group them (e.g. have categories for basic use, dataviz, <:Window>, nested components, events, what-have-you).

Also, this depends on sveltejs/svelte#432 — will blitz through all the outstanding PRs tomorrow.

@Conduitry
Copy link
Member

I was playing around with this a little, using the referenced PR against Svelte.

I noticed that once I switched examples with the dropdown, any changes to the input were not reflected in the output code or the output HTML. Switching back and forth between input and output showed me the original input again, upon which edits to the input correctly updated the output code and HTML.

With the multi-component example, I'm able to get the nested component input to magically replace the containing component input - although I'm not sure what consistent steps to get this to happen are.

One other thing - are there some files in public/ that should be gitignored? The new rollup.browser.js, and also a couple of CodeMirror files?

@Rich-Harris
Copy link
Member Author

Thanks — yes, those files need to be ignored. I experienced the same weirdness with bindings until I trashed my node_modules folder and reinstalled everything, it seems to be fixed now...

@Rich-Harris Rich-Harris changed the title [WIP] Multiple components Multiple components Apr 2, 2017
@Rich-Harris Rich-Harris merged commit f5e89bc into master Apr 2, 2017
@Rich-Harris Rich-Harris deleted the gh-12 branch April 2, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants