use textContent and innerHTML where appropriate #860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #23. Any time you have an element that contains no if/each blocks, tags, components, or elements with bindings/refs/transitions/dynamic attributes, we can just use
innerHTML
(ortextContent
, if there's only a single text node child) instead of constructing the DOM programmatically.There's some evidence that this is slightly slower on microbenchmarks, but I think we're talking about very modest differences. In return, we get leaner, more readable generated code.
We could generate all DOM that doesn't contain if/each blocks this way, like this...
...but this PR doesn't go that far.
Thoughts?