[fix] Correct cleanup when stylesheets are appended to dom from transitions #7259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f making them empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lintResolves
What has been changed?
The
style_managercleaned up its stylesheets in theclear_rulesby removing all their rules. After looping through all of the managed_styles, it cleared itself by runningmanaged_styles.clear(). By doing this it removed all of its references to the empty stylesheets, causing them to be left in the DOM.The proposed change is to remove the style-element created by the
style_managercompletely instead of making them empty and letting them stay in the DOM. I also refactored some of the methods from theruntime/internal/dom.tsfile that were only used by thestyle_manageror in thedom.ts fileitself.