Fire intro.start and outro.start events #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #702. This PR looks slightly more involved than might be expected from the title, which is because I think we need to satisfy the following constraints:
[in|ou]tro.startevents should fire duringcomponent.set(...), not in the next tick. That way, it's easy to collect all the start events associated with a particular update — could get confusing otherwisethis.on('intro.start', ...)insideoncreatein time to capture any intros that happen on initial renderBecause of that, we need to separate
_oncreatefrom_postcreate, and control the order in which functions are called. I think the end result is actually slightly more logical/readable than what we had before.