Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prefer context from constructor options #6759

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

Conduitry
Copy link
Member

This fixes #6753 and also fixes it for SSR so that the passed context is preferred, even when we have a parent_component. Browser and SSR are implemented as separate tests, because the process of synchronously creating a child component outside of Svelte's jurisdiction is rather different in the two cases.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 67b53bf into sveltejs:master Sep 22, 2021
@Conduitry Conduitry deleted the gh-6753 branch September 22, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when passing getAllContexts() to new Component({ context })
1 participant