Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and tutorial for svelte:fragment #6097

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Add documentation and tutorial for svelte:fragment #6097

merged 5 commits into from
Mar 29, 2021

Conversation

stephane-vanraes
Copy link
Contributor

This adds documentation and tutorial for the svelte:fragment element introduced by #4556

Copy link
Member

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few places where I think the wording could be a little clearer.

Thanks for closing this gap in the docs!

<p>All rights reserved.</p>
<p>Copyright (c) 2019 Svelte Industries</p>
</div>
</Box>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line here?

stephane-vanraes and others added 2 commits March 19, 2021 23:43
Co-authored-by: Geoff Rich <geoff.s.rich@gmail.com>
@stephane-vanraes
Copy link
Contributor Author

Yes you are right, some of the wording is a bit off. Changed with your suggestions 👍

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I left some comments here and there. @tanhauhau could you also take a look?

@dummdidumm dummdidumm merged commit 47e1eee into sveltejs:master Mar 29, 2021
pfz pushed a commit to pfz/svelte that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants