Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix awaited expressions that need parentheses #4283

Merged
merged 3 commits into from
Jan 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Disallow two-way binding to a variable declared by an `{#await}` block ([#4012](https://github.com/sveltejs/svelte/issues/4012))
* Allow access to `let:` variables in sibling attributes on slot root ([#4173](https://github.com/sveltejs/svelte/issues/4173))
* Fix code generation for `await`ed expressions that need parentheses ([#4267](https://github.com/sveltejs/svelte/issues/4267))
* Add some more known globals ([#4276](https://github.com/sveltejs/svelte/pull/4276))
* Correctly apply event modifiers to `<svelte:body>` events ([#4278](https://github.com/sveltejs/svelte/issues/4278))

Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"acorn": "^7.1.0",
"agadoo": "^1.1.0",
"c8": "^5.0.1",
"code-red": "0.0.28",
"code-red": "0.0.30",
"codecov": "^3.5.0",
"css-tree": "1.0.0-alpha22",
"eslint": "^6.3.0",
Expand Down
2 changes: 1 addition & 1 deletion test/js/samples/debug-empty/expected.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class Component extends SvelteComponentDev {
});

const { ctx } = this.$$;
const props = options.props || ({});
const props = options.props || {};

if (/*name*/ ctx[0] === undefined && !("name" in props)) {
console.warn("<Component> was created without expected prop 'name'");
Expand Down
2 changes: 1 addition & 1 deletion test/js/samples/debug-foo-bar-baz-things/expected.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class Component extends SvelteComponentDev {
});

const { ctx } = this.$$;
const props = options.props || ({});
const props = options.props || {};

if (/*things*/ ctx[0] === undefined && !("things" in props)) {
console.warn("<Component> was created without expected prop 'things'");
Expand Down
2 changes: 1 addition & 1 deletion test/js/samples/debug-foo/expected.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class Component extends SvelteComponentDev {
});

const { ctx } = this.$$;
const props = options.props || ({});
const props = options.props || {};

if (/*things*/ ctx[0] === undefined && !("things" in props)) {
console.warn("<Component> was created without expected prop 'things'");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class Component extends SvelteComponentDev {
});

const { ctx } = this.$$;
const props = options.props || ({});
const props = options.props || {};

if (/*foo*/ ctx[0] === undefined && !("foo" in props)) {
console.warn("<Component> was created without expected prop 'foo'");
Expand Down