allow reserved words in tags e.g. {{class}} #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think this is a reasonable compromise. It's a bit of a weird case, but this behavior would probably make some people's lives easier, and it seems unlikely to confuse additional people. One weird edge case I did think of was something like |
|
Does |
|
@PaulBGD That actually works right now without this change. The new shorthand attribute notation doesn't try to parse anything with Acorn so they're fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383. Are we comfortable with this change? It allows
class="{{class}}"which is helpful, but it wouldn't allow e.g.class="{{class + ' other class'}}"since that's a full-blown expression that Acorn would refuse to parse.I think that's probably okay, but if anyone has objections raise them now...