Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-object value of spread attributes variable #3306

Merged
merged 3 commits into from
Sep 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,11 @@ export default class InlineComponentWrapper extends Wrapper {
const value = attr.expression.render(block);
initial_props.push(value);

changes.push(condition ? `${condition} && ${value}` : value);
let value_object = value
if (attr.expression.node.type !== 'ObjectExpression') {
value_object = `@get_spread_object(${value})`;
}
changes.push(condition ? `${condition} && ${value_object}` : value_object);
} else {
const obj = `{ ${quote_name_if_necessary(name)}: ${attr.get_value(block)} }`;
initial_props.push(obj);
Expand Down
4 changes: 4 additions & 0 deletions src/runtime/internal/spread.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ export function get_spread_update(levels, updates) {

return update;
}

export function get_spread_object(spread_props) {
return typeof spread_props === 'object' && spread_props !== null ? spread_props : {};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<script>
export let foo;
export let baz;
export let qux;
export let corge;
</script>

<p>foo: {foo}</p>
<p>baz: {baz}</p>
<p>qux: {qux}</p>
<p>corge: {corge}</p>
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
export default {
props: {
props: {
foo: 'lol',
baz: 40 + 2,
}
},

html: `
<div><p>foo: lol</p>
<p>baz: 42</p>
<p>qux: named</p>
<p>corge: b</p>
`,

test({ assert, component, target }) {
const html = `
<div><p>foo: undefined</p>
<p>baz: undefined</p>
<p>qux: named</p>
<p>corge: b</p>
`;

// test undefined
component.props = undefined;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test null
component.props = null;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test boolean
component.props = true;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test number
component.props = 123;
assert.htmlEqual(target.innerHTML, html);

}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<script>
import Widget from './Widget.svelte';

export let props;

export let corge = false;
export let a = 'a';
export let b = 'b';
</script>

<div>
<Widget corge={corge ? a : b} {...props} qux="named"/>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<script>
export let foo;
export let baz;
export let qux;
</script>

<p>foo: {foo}</p>
<p>baz: {baz}</p>
<p>qux: {qux}</p>
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
export default {
props: {
props: {
foo: 'lol',
baz: 40 + 2,
}
},

html: `
<div><p>foo: lol</p>
<p>baz: 42</p>
<p>qux: named</p>
`,

test({ assert, component, target }) {
const html = `
<div><p>foo: undefined</p>
<p>baz: undefined</p>
<p>qux: named</p>
`;

// test undefined
component.props = undefined;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test null
component.props = null;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test boolean
component.props = true;
assert.htmlEqual(target.innerHTML, html);

// set object props
component.props = this.props.props;
assert.htmlEqual(target.innerHTML, this.html);

// test number
component.props = 123;
assert.htmlEqual(target.innerHTML, html);

}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<script>
import Widget from './Widget.svelte';

export let props;
</script>

<div>
<Widget {...props} qux="named"/>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<script>
export let i;
export let foo;
export let qux;
</script>

<p>i: {i}</p>
<p>foo: {foo}</p>
<p>qux: {qux}</p>
19 changes: 19 additions & 0 deletions test/runtime/samples/spread-component-side-effects/_config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
export default {
props: {},

html: `
<div><p>i: 1</p>
<p>foo: foo</p>
<p>qux: named</p>
`,

test({ assert, component, target }) {
component.foo = 'lol';

assert.htmlEqual(target.innerHTML, `
<div><p>i: 2</p>
<p>foo: lol</p>
<p>qux: named</p>
`);
}
};
16 changes: 16 additions & 0 deletions test/runtime/samples/spread-component-side-effects/main.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<script>
import Widget from './Widget.svelte';

export let foo = 'foo';

let i = 0

const getProps = (foo) => {
i += 1;
return { foo, i };
}
</script>

<div>
<Widget {...getProps(foo)} qux="named"/>
</div>