Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Appveyor's configuration #2991

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

mrkishi
Copy link
Member

@mrkishi mrkishi commented Jun 9, 2019

Follow up to #2970, also make sure we support node v8+ on Windows.

@Conduitry
Copy link
Member

This seems good for now, but it might be nice sometime to switch to Travis's multi-OS builds and get rid of Appveyor.

@Conduitry
Copy link
Member

@shinnn
Copy link
Contributor

shinnn commented Jun 9, 2019

I don't know what to make of that.

appveyor/ci#2921 hasn't been fixed yet.

@mrkishi
Copy link
Member Author

mrkishi commented Jun 9, 2019

Eek. Used the update path instead.

- ps: Install-Product node $env:nodejs_version
- npm install
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
- npm ci || npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this || npm install fallback is not needed, because npm CLI update was backported to Node.js 8.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@Conduitry
Copy link
Member

Huh. After over a month v12 still isn't available in the standard way? Maybe this is another reason to move to Travis for this sooner rather than later.

@Rich-Harris Rich-Harris merged commit 593de0e into sveltejs:master Jun 10, 2019
@Rich-Harris
Copy link
Member

How straightforward is it to get things up and running on Travis?

@Conduitry
Copy link
Member

Here's the config I used for cheap-watch, and everything Just Worked. Although I'm realizing now that I'm not sure how this would deal with the custom element tests in puppeteer.

@mrkishi mrkishi deleted the update-appveyor branch June 10, 2019 01:16
@paulocoghi
Copy link
Contributor

paulocoghi commented Jun 10, 2019

@Conduitry

This seems good for now, but it might be nice sometime to switch to Travis's multi-OS builds and get rid of Appveyor.

I believe that Travis doesn't support Windows (at least not on the free version for open source projects). On my research to multi OS tests, I was able to test Linux and OSX on Travis with:

And Appveyor is my only option today for Windows tests.

Do your Windows tests on Travis also work on free accounts?


Although I'm realizing now that I'm not sure how this would deal with the custom element tests in puppeteer.

I'm using puppeteer on the tests of my library liven (that replace livereload and browser-sync), both on Travis and Appveyor with no issues, using the official method: https://jestjs.io/docs/en/puppeteer

@Conduitry
Copy link
Member

I'm using a Windows build on Travis in the project I linked to in my previous comment, and I'm not paying them.

@paulocoghi
Copy link
Contributor

Wow. Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants