Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure $store reads are properly transformed #12951

Closed
wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

The backing store variable of a $store read could be a variable that itself needs a transformer, which is why we need to move the setup of the store transformers to the end of the chain

fixes #12859

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The backing `store` variable of a `$store` read could be a variable that itself needs a transformer, which is why we need to move the setup of the store transformers to the end of the chain

fixes #12859
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: ae0a312

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

I think we can fix this more simply — rather than being careful about the order in which transformers are added (it shouldn't matter), we just avoid transforming the store binding eagerly. Opened #12952

@dummdidumm
Copy link
Member Author

Closing in favor of #12952

@dummdidumm dummdidumm closed this Aug 21, 2024
@dummdidumm dummdidumm deleted the store-read-fix branch August 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Setting a store tries to update the signal instead in certain situations
3 participants