Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove $state.link callback #12942

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

See #12938 (comment) (and #12545 for the original PR).

I regretted this API almost as soon as I merged it. Short of removing $state.link altogether, I'm pretty certain that we should remove the callback version — if you need to do something more complicated than having a local piece of state immediately update when some other state changes, use an effect. Whether or not a dedicated API for the remaining use case (which is very narrow) is warranted is a live question, I think, but hopefully we can get agreement on this more limited change before too much damage is done from having the current version in the wild.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 1a4008e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Aug 20, 2024

Agreed 100%

@Rich-Harris
Copy link
Member Author

See also #12943

@Rich-Harris Rich-Harris merged commit 0b51ff0 into main Aug 21, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the remove-state-link-callback branch August 21, 2024 13:49
@Rich-Harris
Copy link
Member Author

Releasing this pending resolution on the broader question of #12943

Rich-Harris added a commit that referenced this pull request Aug 21, 2024
Rich-Harris added a commit that referenced this pull request Aug 21, 2024
* Revert "breaking: remove `$state.link` callback (#12942)"

This reverts commit 0b51ff0.

* Revert "feat: adds $state.link rune (#12545)"

This reverts commit 63ec2e2.

* put changesets back

* changeset

* merge main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants