Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group outro callbacks #1157

Merged
merged 9 commits into from
May 6, 2018
Merged

Group outro callbacks #1157

merged 9 commits into from
May 6, 2018

Conversation

Rich-Harris
Copy link
Member

Started having a go at #648, but ran aground — will take a larger rethink than I have time for right now. Just going to leave the failing test here

@Rich-Harris Rich-Harris changed the title failing test for #648 Group outro callbacks May 6, 2018
@Rich-Harris
Copy link
Member Author

Okay, this is working. The code is a little inelegant, I may try and neaten it up in the morning.

This also fixes #1426.

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #1157 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   91.02%   91.15%   +0.13%     
==========================================
  Files         122      122              
  Lines        4488     4489       +1     
  Branches     1404     1405       +1     
==========================================
+ Hits         4085     4092       +7     
  Misses        158      158              
+ Partials      245      239       -6
Impacted Files Coverage Δ
src/compile/nodes/EachBlock.ts 97.95% <ø> (ø) ⬆️
src/compile/nodes/IfBlock.ts 96.55% <ø> (ø) ⬆️
src/compile/nodes/Element.ts 92.87% <ø> (+0.24%) ⬆️
src/compile/dom/Block.ts 93.13% <0%> (+0.98%) ⬆️
src/compile/nodes/Component.ts 96.18% <0%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c46de...9f61843. Read the comment docs.

@Rich-Harris Rich-Harris merged commit e1db827 into master May 6, 2018
@Rich-Harris Rich-Harris deleted the gh-648 branch May 6, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants