Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only inject push/init/pop when necessary #11319

Merged
merged 10 commits into from
Apr 25, 2024
Merged

feat: only inject push/init/pop when necessary #11319

merged 10 commits into from
Apr 25, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 24, 2024

closes #11297. TODO:

  • remove $$props argument where possible
  • identify 'safe' call expressions/member expressions

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 6b75207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a false negative, see comment.
Also: Do we really need the "needs props" logic? Seems totally harmless to have an unused parameter, it's going to get treeshaken out - not sure it's worth the additional code/maintenance

packages/svelte/src/compiler/phases/2-analyze/index.js Outdated Show resolved Hide resolved
@Rich-Harris
Copy link
Member Author

Obviously it'll differ from tool to tool, but unused parameters are not treeshaken out by Rollup, because that would affect fn.length which is dangerous. But if you remove the parameter yourself, Rollup is able to throw out the corresponding arguments:

image

(We can't just omit the props when calling the function, because then the child component would need to be defensive, which would undo the gains and then some)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: only inject push/init/pop when necessary
2 participants