emit dev mode error for bad arguments to set #1000

Rich-Harris · 2017-12-10T03:06:09Z

fixes #990

codecov-io · 2017-12-10T03:11:44Z

Codecov Report

Merging #1000 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1000   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         115      115           
  Lines        4271     4271           
  Branches     1359     1359           
=======================================
  Hits         3929     3929           
  Misses        148      148           
  Partials      194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8eaa7e...80f5a7c. Read the comment docs.

Rich-Harris added 30 commits December 5, 2017 22:28

start moving logic into Node and its subclasses

2e56d10

remove unused code

4b31992

start implementing build() methods

39f1af2

start moving build logic into individual nodes

8e9e323

move some code around

c6d49b7

remove some unused code

daaad80

move Slot logic

e8e05e7

move attribute logic

425d019

move binding logic

8072f6a

move shared MustacheTag/RawMustacheTag logic

596c432

remove elementStack

56f34c7

remove componentStack

fd24a5c

remove inEachBlock

0cf9259

Merge branch 'master' into gh-979

67aca17

fix a few typescript issues

f4888dd

remove confusing state object from init

7f77a10

remove some unused stuff

f6ac3a4

put namespace on Element nodes

e30dc8e

tidy up

8eacc25

more tidying up

48ed685

simplify

05d63e6

more simplification

16bac3b

rename some stuff to be clearer

433623c

remove unused imports

afa996c

DRY out

e9dc123

more tidying up

ea418cd

rename _block to block

3fa83e3

remove preprocess from ssr renderer

9b2a7e1

more tidying up

e974fdc

small tweak, possibly ahead of a much larger one

a72a6ca

Rich-Harris added 3 commits December 9, 2017 18:48

tidy up

f7d4994

remove unused code

cf94217

emit dev mode error for bad arguments to set - fixes #990

ca63c11

Merge branch 'master' into gh-990

80f5a7c

Rich-Harris merged commit 81f4490 into master Dec 10, 2017

Rich-Harris deleted the gh-990 branch December 10, 2017 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

emit dev mode error for bad arguments to set #1000

emit dev mode error for bad arguments to set #1000

Rich-Harris commented Dec 10, 2017

codecov-io commented Dec 10, 2017 •

edited

Loading

emit dev mode error for bad arguments to set #1000

emit dev mode error for bad arguments to set #1000

Conversation

Rich-Harris commented Dec 10, 2017

codecov-io commented Dec 10, 2017 • edited Loading

Codecov Report

codecov-io commented Dec 10, 2017 •

edited

Loading