-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
todomvc is not working on old Android device #431
Comments
Thanks. My hunch is that it's because Svelte generates code that uses If there's any way to get an error log by remotely inspecting the browser over USB, that would be amazing, but if not then I'll try deploying a version with a polyfill later to see if that works. |
According to Google, @ceremcem Could you check out ES Checker with that device + browser? Support tables indicate a good support |
It's Chrome, yes. I followed that instructions (thank you, I learned something else 👍 ), and your guess is correct. Here is the console output:
|
MDN has a polyfill. |
So, there are two possible routes here:
Since we don't need to cover all the edge cases that a true polyfill would, ours could be as simple as export function assign ( target ) {
for ( var i = 1; i < arguments.length; i += 1 ) {
var source = arguments[i];
for ( var k in source ) target[k] = source[k];
}
return target;
} |
So I understand that the issue is not related directly with Svelte itself? If so, this issue can be closed. |
Oh, btw. I haven't heard of that ES Checker before, too. Action derived from this issue is offering an @Rich-Harris I wonder whether it is worth the effort to implement a Babel-like API to polyfill ESnext features according to presets/target browser versions... |
It's related to Svelte insofar as it affects the environments we can plausibly claim to support. Some people still have to get their apps working on IE9, legacy Android etc... if it's no bother for us to bake in support (or offer it via e.g. a
Nah, not at this stage. Maybe if we decided to e.g. implement something using |
Thanks. Writing parsers sounds like too much what Computer Scientists would do, so I haven't tried to understand how it works, yet (knowledge gap is too large). Good to know, that most is ES5 code! |
use assign helper, to avoid compatibility headaches
I've just deployed a new version of TodoMVC — hopefully it works on old Android now: https://svelte-todomvc.surge.sh |
http://svelte-todomvc.surge.sh/#/ is not working on my Android 4.0.3 and is shown as follows:
I don't know which information should I deliver to help debugging.
The text was updated successfully, but these errors were encountered: