-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't like commented out CSS #252
Comments
Oh, interesting. Reproduced in the REPL here — looks like the comment delimiters are being mistaken for part of the selector, and being erroneously duplicated: Not hugely surprising, since the CSS transformer is just a big mess of regexes. Relevant XKCD: Might be time to start investigating implementing a proper CSS parser, as per #245 (comment) discussion. In the meantime, workarounds are a) removing comments, or b) putting them on a single line. |
A proper CSS parser would be ideal. For a quick fix though, here's where the regex wizard addressed the same issue when it arose in Ractive: https://github.com/ractivejs/ractive/pull/2684/files. It looks like it would be a super simple patch. |
Of course! I should have known @MartinKolarik would have fixed this already — the finest regex warrior I ever rode into battle with. Preparing a PR now — thanks @evs-chris |
fixed in 1.6.4, thanks everyone |
Oh yeah, regular expressions are fun 😆 |
It appears that commented out CSS causes problems ...
I.e.
The Arial/14px doesn't work unless I delete the table class.
The text was updated successfully, but these errors were encountered: