Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY out SSR/DOM compilers #202

Closed
Rich-Harris opened this issue Dec 16, 2016 · 0 comments
Closed

DRY out SSR/DOM compilers #202

Rich-Harris opened this issue Dec 16, 2016 · 0 comments

Comments

@Rich-Harris
Copy link
Member

Due to the SSR compiler's origins as a separate package, there's a lot of duplicate code that could be removed. Might even make sense to have a single meta-compiler, that takes visitors as an argument. (Haven't looked into how realistic that is though.)

Would make sense to do that before implementing non-CJS exports from the SSR compiler per #196 (comment)
@Rich-Harris Rich-Harris mentioned this issue Dec 16, 2016
Merged
Rich-Harris added a commit that referenced this issue Dec 17, 2016
@Rich-Harris
merge master -> gh-202
c849912
Rich-Harris added a commit that referenced this issue Dec 17, 2016
@Rich-Harris
Merge pull request #204 from sveltejs/gh-202
7cd8683 
Refactoring generator code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rich-Harris