Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing exceptions from Acorn for directives not correctly mapped to row/column #1788

Closed
Conduitry opened this issue Oct 19, 2018 · 3 comments · Fixed by #1789
Closed

Parsing exceptions from Acorn for directives not correctly mapped to row/column #1788

Conduitry opened this issue Oct 19, 2018 · 3 comments · Fixed by #1789

Comments

@Conduitry
Copy link
Member

See e.g. https://svelte.technology/repl?version=2.14.0&gist=16755c91f5a1bb2bf2a587b1aa72e347

The error is displayed as being on line 1 column 80, when it is in fact at character 80.

cc @TehShrike
@Conduitry
Copy link
Member Author

Aha - well this seems fishy!

@Conduitry
Copy link
Member Author

PR incoming

@Conduitry Conduitry mentioned this issue Oct 19, 2018
Merged
@Conduitry Conduitry changed the title Parsing exceptions from Acorn not correctly mapped to row/column Parsing exceptions from Acorn for directives not correctly mapped to row/column Oct 19, 2018
@Conduitry
Copy link
Member Author

Submitted PR and updated issue title - afaict, this only applies to expressions in directives, not elsewhere

Rich-Harris added a commit that referenced this issue Oct 20, 2018
@Rich-Harris
Merge pull request #1789 from sveltejs/gh-1788
9395573 
adjust parsing of directives to preserve line/column info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adjust parsing of directives to preserve line/column info sveltejs/svelte
1 participant
@Conduitry